Skip to content
This repository has been archived by the owner on Apr 13, 2022. It is now read-only.

feat(ngHref): bind href attribute to ng-href attribute in case SVG el… #15694

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

m-amr
Copy link
Contributor

@m-amr m-amr commented Feb 9, 2017

…ement

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature that solve #15618

What is the current behavior? (You can also link to an open issue here)
href attribute doesn't bind to ng-href in case of SVG element

What is the new behavior (if this is a feature change)?
href attribute binds to ng-href in case of SVG element

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

Other information:

@m-amr m-amr force-pushed the bind_href_in_svg branch 2 times, most recently from 43ebe65 to c400a29 Compare February 9, 2017 04:47
@gkalpak
Copy link
Member

gkalpak commented Feb 9, 2017

I think we will need a lot more changes (e.g. here, here, here and probably elsewhere) and more tests and security reviews. TBH, I am not sure it is worth it at this point (until the spec is finallized and implemented by browsers).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants