function isModuleDefined #16569

linjianhong · 2018-05-18T03:12:54Z

I'm submitting a ...

bug report
feature request
other

Current behavior:
When redefine module, orgin module lost.

Expected / new behavior:
Override a module, or do something whether the modele is defined or not.

Minimal reproduction of the problem with instructions:
none

AngularJS version: 1.x.y
all

Browser: [all]

Anything else:
before the code:

      if (requires && modules.hasOwnProperty(name)) {
        modules[name] = null;
      }

add:

      if(isBoolean(requires)){
        return modules.hasOwnProperty(name);
      }

then I can user like this:

      if(angular.module('my-module', true)){
        // codes
      }
      else{
        // codes if not exit module 'my-module'
      }

The text was updated successfully, but these errors were encountered:

gkalpak · 2018-05-18T08:16:40Z

If we decided to implement this, we should not overload the angular.module() helper, but introduce a new one (e.g. angular.hasModule('<module-name>')). But given that writing your own helper is very easy (and taking into account that AngularJS is just about to enter LTS), I would lean towards not adding it. You can create it yourself like this:

angular.hasModule = function hasModule(moduleName) {
  try {
    angular.module(moduleName);
    return true;
  } catch (_ignored) {
    return false;
  }
};

linjianhong · 2018-05-22T14:37:21Z

In fact, I did exactly the same. It's just that this hack doesn't look elegant enough. Usually, I try not to let the code of the catch block run.
Thank you so much!

gkalpak added type: feature component: misc core labels May 18, 2018

gkalpak added this to the 1.7.x milestone May 18, 2018

petebacondarwin modified the milestones: 1.7.x, 1.7.x - won't fix Sep 19, 2018

function isModuleDefined #16569

function isModuleDefined #16569

linjianhong commented May 18, 2018

gkalpak commented May 18, 2018 •

edited

linjianhong commented May 22, 2018

function isModuleDefined #16569

function isModuleDefined #16569

Comments

linjianhong commented May 18, 2018

gkalpak commented May 18, 2018 • edited

linjianhong commented May 22, 2018

gkalpak commented May 18, 2018 •

edited