Added disclaimer about the level of experience required in the first paragraph to beginning users. #17068

stevenrugg · 2020-08-28T12:03:06Z

added disclaimer for beginning users

AngularJS is in LTS mode

We are no longer accepting changes that are not critical bug fixes into this project.
See https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c for more detail.

Does this PR fix a regression since 1.7.0, a security flaw, or a problem caused by a new browser version?

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills these requirements

The commit message follows our guidelines
Fix/Feature: Docs have been added/updated
Fix/Feature: Tests have been added; existing tests pass

Other information:

added disclaimer for beginning users

googlebot · 2020-08-28T12:03:11Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

stevenrugg · 2020-08-30T00:31:26Z

I signed it

…

________________________________ From: googlebot <notifications@github.com> Sent: Friday, August 28, 2020 5:03 AM To: angular/angular.js <angular.js@noreply.github.com> Cc: Steven Rugg <Steven.rugg@outlook.com>; Author <author@noreply.github.com> Subject: Re: [angular/angular.js] Added disclaimer in the first paragraph to beginning users. (#17068) Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

________________________________ What to do if you already signed the CLA Individual signers * It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data<https://cla.developers.google.com/clas> and verify that your email is set on your git commits<https://help.github.com/articles/setting-your-email-in-git/>. Corporate signers * Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot<http://go/cla#troubleshoot> (Public version<https://opensource.google/docs/cla/#troubleshoot>). * The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data<https://cla.developers.google.com/clas> and verify that your email is set on your git commits<https://help.github.com/articles/setting-your-email-in-git/>. * The email used to register you as an authorized contributor must also be attached to your GitHub account<https://github.com/settings/emails>. ℹ️ Googlers: Go here<https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fangular%2Fangular.js%2Fpull%2F17068> for more info. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#17068 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKPPUDAQSI2EYZSDHMT5GJDSC6MI7ANCNFSM4QOBXWZA>.

googlebot · 2020-08-30T00:31:32Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

stevenrugg · 2020-08-30T00:31:43Z

@googlebot I signed it

…

________________________________ From: googlebot <notifications@github.com> Sent: Friday, August 28, 2020 5:03 AM To: angular/angular.js <angular.js@noreply.github.com> Cc: Steven Rugg <Steven.rugg@outlook.com>; Author <author@noreply.github.com> Subject: Re: [angular/angular.js] Added disclaimer in the first paragraph to beginning users. (#17068) Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

________________________________ What to do if you already signed the CLA Individual signers * It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data<https://cla.developers.google.com/clas> and verify that your email is set on your git commits<https://help.github.com/articles/setting-your-email-in-git/>. Corporate signers * Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot<http://go/cla#troubleshoot> (Public version<https://opensource.google/docs/cla/#troubleshoot>). * The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data<https://cla.developers.google.com/clas> and verify that your email is set on your git commits<https://help.github.com/articles/setting-your-email-in-git/>. * The email used to register you as an authorized contributor must also be attached to your GitHub account<https://github.com/settings/emails>. ℹ️ Googlers: Go here<https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fangular%2Fangular.js%2Fpull%2F17068> for more info. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#17068 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKPPUDAQSI2EYZSDHMT5GJDSC6MI7ANCNFSM4QOBXWZA>.

Splaktar · 2020-09-30T18:24:11Z

docs/content/tutorial/index.ngdoc

@@ -5,6 +5,11 @@

 # PhoneCat Tutorial App

+*** This tutorial assumes that the reader has a basic knowledge of HTML, CSS and Javascript. If you have no 


Suggested change

*** This tutorial assumes that the reader has a basic knowledge of HTML, CSS and Javascript. If you have no

*** This tutorial assumes that the reader has a fundamental knowledge of HTML, CSS, and JavaScript. If you have no

Splaktar · 2020-09-30T18:24:20Z

docs/content/tutorial/index.ngdoc

@@ -5,6 +5,11 @@

 # PhoneCat Tutorial App

+*** This tutorial assumes that the reader has a basic knowledge of HTML, CSS and Javascript. If you have no 
+experience coding or have not been introduced to Javascript, we highly suggest that you take some time


Suggested change

experience coding or have not been introduced to Javascript, we highly suggest that you take some time

experience coding or have not been introduced to JavaScript, we highly suggest that you take some time

Splaktar · 2020-09-30T18:24:45Z

docs/content/tutorial/index.ngdoc

@@ -5,6 +5,11 @@

 # PhoneCat Tutorial App

+*** This tutorial assumes that the reader has a basic knowledge of HTML, CSS and Javascript. If you have no 
+experience coding or have not been introduced to Javascript, we highly suggest that you take some time
+to learn the basics of Javascript by going to https://www.javascript.com/learn/strings or 


Suggested change

to learn the basics of Javascript by going to https://www.javascript.com/learn/strings or

to learn the basics of JavaScript by going to [MDN's JavaScript guide](https://developer.mozilla.org/en-US/docs/Web/JavaScript).

Splaktar · 2020-09-30T18:26:22Z

docs/content/tutorial/index.ngdoc

+*** This tutorial assumes that the reader has a basic knowledge of HTML, CSS and Javascript. If you have no 
+experience coding or have not been introduced to Javascript, we highly suggest that you take some time
+to learn the basics of Javascript by going to https://www.javascript.com/learn/strings or 
+https://www.w3schools.com/js/. ***


Suggested change

https://www.w3schools.com/js/. ***

Splaktar · 2020-09-30T18:28:19Z

Also from CI:

Invalid commit message, please fix:

- <subject> must not end with a dot

Commit message was:

docs(tutorial/Tutorial): describe your change...

added disclaimer for beginning users

See https://bit.ly/angular-guidelines

You can find more at https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#commits

docs(tutorial/Tutorial): describe your change...

fa124a5

added disclaimer for beginning users

googlebot added the cla: no label Aug 28, 2020

stevenrugg changed the title ~~Added disclaimer in the first paragraph to beginning users.~~ Added disclaimer about the level of experience required in the first paragraph to beginning users. Aug 28, 2020

googlebot added cla: yes and removed cla: no labels Aug 30, 2020

Splaktar suggested changes Sep 30, 2020

View reviewed changes

Added disclaimer about the level of experience required in the first paragraph to beginning users. #17068

Added disclaimer about the level of experience required in the first paragraph to beginning users. #17068

stevenrugg commented Aug 28, 2020 •

edited

googlebot commented Aug 28, 2020

stevenrugg commented Aug 30, 2020 via email

googlebot commented Aug 30, 2020

stevenrugg commented Aug 30, 2020 via email

Splaktar Sep 30, 2020

Splaktar Sep 30, 2020

Splaktar Sep 30, 2020

Splaktar Sep 30, 2020

Splaktar commented Sep 30, 2020

		@@ -5,6 +5,11 @@

		# PhoneCat Tutorial App

		*** This tutorial assumes that the reader has a basic knowledge of HTML, CSS and Javascript. If you have no

	experience coding or have not been introduced to Javascript, we highly suggest that you take some time
	experience coding or have not been introduced to JavaScript, we highly suggest that you take some time

	to learn the basics of Javascript by going to https://www.javascript.com/learn/strings or
	to learn the basics of JavaScript by going to [MDN's JavaScript guide](https://developer.mozilla.org/en-US/docs/Web/JavaScript).

Added disclaimer about the level of experience required in the first paragraph to beginning users. #17068

Are you sure you want to change the base?

Added disclaimer about the level of experience required in the first paragraph to beginning users. #17068

Conversation

stevenrugg commented Aug 28, 2020 • edited

AngularJS is in LTS mode

googlebot commented Aug 28, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

stevenrugg commented Aug 30, 2020 via email

googlebot commented Aug 30, 2020

stevenrugg commented Aug 30, 2020 via email

Splaktar Sep 30, 2020

Choose a reason for hiding this comment

Splaktar Sep 30, 2020

Choose a reason for hiding this comment

Splaktar Sep 30, 2020

Choose a reason for hiding this comment

Splaktar Sep 30, 2020

Choose a reason for hiding this comment

Splaktar commented Sep 30, 2020

stevenrugg commented Aug 28, 2020 •

edited