This repository has been archived by the owner on Apr 13, 2022. It is now read-only.
docs(changelog): fix typos in 1.8.1/1.8.2 notes #17093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove stray backtick. - Add missing preposition (`identical` --> `identical to`). - Remove 1.8.1 change from the 1.8.2 section.
mgol
reviewed
Oct 24, 2020
CHANGELOG.md
Outdated
| @@ -28,7 +26,7 @@ | |||
| ## Deprecation Notices | |||
|
|
|||
| - Deprecated ~~`$compileProvider.aHrefSanitizationWhitelist`~~. | |||
| It is now [aHrefSanitizationTrustedUrlList](https://docs.angularjs.org/api/ng/provider/$compileProvider#aHrefSanitizationTrustedUrlList)`. | |||
| It is now [aHrefSanitizationTrustedUrlList](https://docs.angularjs.org/api/ng/provider/$compileProvider#aHrefSanitizationTrustedUrlList). | |||
There was a problem hiding this comment.
I'd suggest using backticks for the name, this would be more compatible with how the replaced APIs are written. E.g. here:
Suggested change
| It is now [aHrefSanitizationTrustedUrlList](https://docs.angularjs.org/api/ng/provider/$compileProvider#aHrefSanitizationTrustedUrlList). | |
| It is now [`aHrefSanitizationTrustedUrlList`](https://docs.angularjs.org/api/ng/provider/$compileProvider#aHrefSanitizationTrustedUrlList). |
Similar changes can be done for all other lines here.
gkalpak
added a commit
that referenced
this pull request
Oct 25, 2020
- Remove stray backtick. - Add missing preposition (`identical` --> `identical to`). - Remove 1.8.1 change from the 1.8.2 section. Closes #17093
AnkushLambdatest
pushed a commit
to AnkushLambdatest/angular.js
that referenced
this pull request
Jun 29, 2022
- Remove stray backtick. - Add missing preposition (`identical` --> `identical to`). - Remove 1.8.1 change from the 1.8.2 section. Closes angular#17093
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
identical-->identical to).