Skip to content
This repository has been archived by the owner on Apr 13, 2022. It is now read-only.

chore(build): support NodeJS LTS v14. fix audit issues #17139

Closed
wants to merge 1 commit into from
Closed

chore(build): support NodeJS LTS v14. fix audit issues #17139

wants to merge 1 commit into from

Conversation

Splaktar
Copy link
Member

@Splaktar Splaktar commented Jun 5, 2021 •
edited

AngularJS is in LTS mode

We are no longer accepting changes that are not critical bug fixes into this project.
See https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c for more detail.

Does this PR fix a regression since 1.7.0, a security flaw, or a problem caused by a new browser version?
Yes

What is the current behavior? (You can also link to an open issue here)

  • from:483 vulnerabilities found - 273 Low | 38 Moderate | 168 High | 4 Critical
  • NodeJS v12 is used

What is the new behavior (if this is a feature change)?

  • to: 389 vulnerabilities found - 259 Low | 28 Moderate | 98 High | 4 Critical
  • NodeJS LTS v14 is used, the same version as the other Angular repos.

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Fix/Feature: Docs have been added/updated
  • Fix/Feature: Tests have been added; existing tests pass

Other information:

  • This doesn't fix audit issues with the Firebase functions. I plan to do that in a separate PR.
  • This doesn't fix all audit issues as I wanted to keep this to a smaller batch as I anticipate future fixes to have more widely breaking changes. This batch is lower risk.
  • I tested doc gen and rendering, commit log generation, and building manually in addition to the CI tests.

@Splaktar
chore(build): support NodeJS LTS v14. fix audit issues
152094d 
- from:483 vulnerabilities found - 273 Low | 38 Moderate | 168 High | 4 Critical
- to: 389 vulnerabilities found - 259 Low | 28 Moderate | 98 High | 4 Critical
@google-cla google-cla bot added the cla: yes label Jun 5, 2021
@Splaktar
Copy link
Member Author

Splaktar commented Jun 5, 2021 •
edited

This should resolve the following dependabot PRs:

@gkalpak gkalpak closed this in c140d89 Jun 5, 2021
gkalpak pushed a commit that referenced this pull request Jun 5, 2021
@Splaktar @gkalpak
chore(build): support NodeJS LTS v14. fix audit issues
8e53378 
- from:483 vulnerabilities found - 273 Low | 38 Moderate | 168 High | 4 Critical
- to: 389 vulnerabilities found - 259 Low | 28 Moderate | 98 High | 4 Critical

Closes #17139
@Splaktar Splaktar deleted the fix-audit-warnings branch June 5, 2021 19:14
@sakibguy sakibguy mentioned this pull request Jun 6, 2021
Merged
3 tasks
AnkushLambdatest pushed a commit to AnkushLambdatest/angular.js that referenced this pull request Jun 29, 2022
@Splaktar
chore(build): support NodeJS LTS v14. fix audit issues
bc35982 
- from:483 vulnerabilities found - 273 Low | 38 Moderate | 168 High | 4 Critical
- to: 389 vulnerabilities found - 259 Low | 28 Moderate | 98 High | 4 Critical

Closes angular#17139
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
cla: yes type: chore type: infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Splaktar @gkalpak