Skip to content
This repository has been archived by the owner on Apr 13, 2022. It is now read-only.

chore(functions): support NodeJS LTS v14. fix audit issues #17140

Closed

Conversation

Splaktar
Copy link
Member

@Splaktar Splaktar commented Jun 5, 2021

AngularJS is in LTS mode

We are no longer accepting changes that are not critical bug fixes into this project.
See https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c for more detail.

Does this PR fix a regression since 1.7.0, a security flaw, or a problem caused by a new browser version?
Yes

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

  • update firebase scripts
  • to: 0 vulnerabilities found

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Fix/Feature: Docs have been added/updated
  • Fix/Feature: Tests have been added; existing tests pass

Other information:

- update firebase scripts
- from: 6 vulnerabilities found - Severity: 6 High
- to: 0 vulnerabilities found
@google-cla google-cla bot added the cla: yes label Jun 5, 2021
@Splaktar
Copy link
Member Author

Splaktar commented Jun 5, 2021

There is a warning when doing yarn install

warning "firebase-admin > @firebase/database > @firebase/auth-interop-types@0.1.5" has unmet peer dependency "@firebase/app-types@0.x".

But that is an issue with Firebase that is fixed in firebase/firebase-js-sdk#4087.

@gkalpak gkalpak closed this in c3769a6 Jun 7, 2021
gkalpak pushed a commit that referenced this pull request Jun 7, 2021
- update firebase scripts
- from: 6 vulnerabilities found - Severity: 6 High
- to: 0 vulnerabilities found

Closes #17140
@Splaktar Splaktar deleted the fix-functions-audit-warnings branch June 7, 2021 18:52
AnkushLambdatest pushed a commit to AnkushLambdatest/angular.js that referenced this pull request Jun 29, 2022
- update firebase scripts
- from: 6 vulnerabilities found - Severity: 6 High
- to: 0 vulnerabilities found

Closes angular#17140
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants