docs: update end-of-life messages #17177

jelbourn · 2022-01-31T22:10:08Z

This change updates the messaging about AngularJS end-of-life in several places:

Docs homepage
Docs banner
Security and support pages
GitHub README

@gkalpak am I missing anything here? I also want to update the changelog, but assume that happens automatically as part of the release process?

Splaktar

The commit message needs to be updated to something like the following to pass the lint checks:

docs(*): update end-of-life messages

I'm just posting the feedback that I was able to get through so far. I got pulled away and will have to finish reviewing/providing feedback later.

Splaktar · 2022-02-01T20:32:13Z

README.md

+**[Support for legacy AngularJS has fully ended.](https://goo.gle/angularjs-end-of-life)**
+**Visit https://github.com/angular/angular for the actively supported Angular framework.**


I feel like just saying "Support for legacy AngularJS has fully ended." is a bit too final and may have low clickability. This may lead to frustrated community members who just rage close the browser rather than clicking on the link and reading it to find out that they have some options for moving forward (in a separate blog post). Because of this, I think that there is still value in having some text and a link to the "Finding a Path Forward with AngularJS" blog post.

Suggested change

**[Support for legacy AngularJS has fully ended.](https://goo.gle/angularjs-end-of-life)**

**Visit https://github.com/angular/angular for the actively supported Angular framework.**

**[Support for legacy AngularJS has fully ended](https://goo.gle/angularjs-end-of-life). [Find a path forward](https://blog.angular.io/finding-a-path-forward-with-angularjs-7e186fdd4429).**

**Visit https://github.com/angular/angular for the actively supported Angular framework.**

or

Suggested change

**[Support for legacy AngularJS has fully ended.](https://goo.gle/angularjs-end-of-life)**

**Visit https://github.com/angular/angular for the actively supported Angular framework.**

**[Support for legacy AngularJS has fully ended](https://goo.gle/angularjs-end-of-life).**

**Learn more about [finding a path forward](https://blog.angular.io/finding-a-path-forward-with-angularjs-7e186fdd4429) for your AngularJS app.**

**Visit https://github.com/angular/angular for the actively supported Angular framework.**

or at least adding some text to give them a reason to click:

Suggested change

**[Support for legacy AngularJS has fully ended.](https://goo.gle/angularjs-end-of-life)**

**Visit https://github.com/angular/angular for the actively supported Angular framework.**

**Support for legacy AngularJS has fully ended. Find out [what End-of-Life means](https://goo.gle/angularjs-end-of-life).**

**Visit https://github.com/angular/angular for the actively supported Angular framework.**

In addition to that, I think it would also be useful to include the date when EOL started.

Learn more about finding a path forward for your AngularJS app.

Makes sense to me

Updated the text to this everywhere:

AngularJS support has officially ended as of January 2022. [See what ending support means](https://docs.angularjs.org/misc/version-support-status) and [read the end of life announcement](https://goo.gle/angularjs-end-of-life). Visit [https://angular.io](https://angular.io) for the actively supported Angular.

gkalpak

These are all the places that need updating afaict.

Regarding the changelog, you can manually update it if you want to add an EOL notice. Do we plan on having another release (and if so, what would it include)?

gkalpak · 2022-02-02T10:08:39Z

README.md

+**[Support for legacy AngularJS has fully ended.](https://goo.gle/angularjs-end-of-life)**
+**Visit https://github.com/angular/angular for the actively supported Angular framework.**


In addition to that, I think it would also be useful to include the date when EOL started.

aaronfrost · 2022-02-03T21:39:27Z

SECURITY.md

-[0]: https://docs.angularjs.org/misc/version-support-status#long-term-support
+| Version     | Supported          | Status                | Comments                             |
+| ----------- | ------------------ | --------------------- | ------------------------------------ |
+| 1.8.x       | :x:                | All support ended     |                                      |


Add dates in the comments so that people have a little bit more context.

I've added "as of January 2022" in the paragraph text above

aaronfrost · 2022-02-03T21:50:02Z

docs/config/templates/app/indexPage.template.html

@@ -146,7 +146,8 @@ <h4 class="search-results-group-heading">{{ key }}</h4>
        <div class="navbar-inner">
          <div class="container">
            <p class="site-notice">
-              AngularJS is now in Long Term Support (LTS) mode: <a href="https://docs.angularjs.org/misc/version-support-status">Find out more</a>. Explore End Of Life (EOL) options <a href="https://blog.angular.io/finding-a-path-forward-with-angularjs-7e186fdd4429">here</a>.
+              <a href="https://goo.gle/angularjs-end-of-life">Support for legacy AngularJS has fully ended.</a>
+              Visit <a href="https://angular.io">https://angular.io</a> for the actively supported Angular.
            </p>


For best visibility for those who need to find extended support:

Find out more</a>. Read the <a href=https://github.com/angular/angular.js/pull/"https://goo.gle/angularjs-end-of-life"> End Of Life announcement.</a>">
AngularJS support has officially ended. <a href="https://docs.angularjs.org/misc/version-support-status">Find out more</a>. Read the <a href="https://goo.gle/angularjs-end-of-life"> End Of Life announcement.</a>

Updated the text to this everywhere:

AngularJS support has officially ended as of January 2022. [See what ending support means](https://docs.angularjs.org/misc/version-support-status) and [read the end of life announcement](https://goo.gle/angularjs-end-of-life). Visit [https://angular.io](https://angular.io) for the actively supported Angular.

aaronfrost · 2022-02-03T21:53:16Z

docs/content/api/index.ngdoc

@@ -5,7 +5,8 @@
 # AngularJS API Docs

 <div class="alert alert-warning">
-**On July 1, 2018 AngularJS entered a 3 year Long Term Support period:** [Find out more](misc/version-support-status).
+[Support for legacy AngularJS has fully ended](https://goo.gle/angularjs-end-of-life).
+Visit [https://angular.io](https://angular.io) for the actively supported Angular.
 </div>


I feel like this section could go away since the same page has a banner at the top of the page.

I'd err towards keeping it- doesn't hurt to repeat ourselves.

aaronfrost · 2022-02-03T22:16:05Z

docs/config/templates/app/indexPage.template.html

@@ -146,7 +146,8 @@ <h4 class="search-results-group-heading">{{ key }}</h4>
        <div class="navbar-inner">
          <div class="container">
            <p class="site-notice">
-              AngularJS is now in Long Term Support (LTS) mode: <a href="https://docs.angularjs.org/misc/version-support-status">Find out more</a>. Explore End Of Life (EOL) options <a href="https://blog.angular.io/finding-a-path-forward-with-angularjs-7e186fdd4429">here</a>.
+              <a href="https://goo.gle/angularjs-end-of-life">Support for legacy AngularJS has fully ended.</a>
+              Visit <a href="https://angular.io">https://angular.io</a> for the actively supported Angular.


This "Visit Angular.IO for the actively supported Angular" is not necessary given that right above this section on the index there is a Big Blue button that says "Try The New Angular".

The reason I put this here is because there's some subset of people that this part of the page and jump to the incorrect conclusion that this is referring to Angular. I'd like to keep this message everywhere to prevent that.

aaronfrost · 2022-02-03T22:24:40Z

docs/content/misc/version-support-status.ngdoc

-You can read more about these plans in our [blog post announcement](https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c).
-
-### Extended Long Term Support
+[Visit https://angular.io for the actively supported Angular framework](https://angular.io).


The blog link provided contains all of the relevant info that they could want around dates and time frames and reasons, etc. I feel that it would be more informative to have some quick summarized information here. Instead of deleting this entire section, I would propose:

### End Of Life On December 31, 2021 AngularJS reached End Of Life and is no longer supported. The code will remain accessible through [Github](https://github.com/angular/angular.js) [npm](https://www.npmjs.com/package/angular), [Bower](https://github.com/angular/bower-angular), and [CDN](https://code.angularjs.org/1.8.2). This website will remain here indefinitely. As support has ended, all of the git repos for AngularJS have been locked, which means that it is no longer possible to report issues in AngularJS. Read [the official End Of Life announcement](https://goo.gle/angularjs-end-of-life).

Added a summary here, PTAL

aaronfrost · 2022-02-03T22:25:26Z

docs/content/misc/version-support-status.ngdoc

-
-You can read more about these plans in our [blog post announcement](https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c).
-
-### Extended Long Term Support


Please leave this header.

Added back the header (didn't actually mean to remove it in the first place)

Splaktar · 2022-02-10T19:12:39Z

Some screenshots from running this locally:

Desktop

Pixel 5

We may need to add a bit more spacing on mobile so that the version picker isn't obscured.

Splaktar

LGTM other than the top spacing and overlay conflict on mobile.

Splaktar · 2022-02-10T19:19:29Z

docs/content/misc/version-support-status.ngdoc

+The code will remain accessible on [GitHub](https://github.com/angular/angular.js),
+[npm](https://www.npmjs.com/package/angular),
+[Bower](https://github.com/angular/bower-angular), and
+[CDN](https://code.angularjs.org/1.8.2).


In the past, and in current documentation, there have been warnings for developers to not use code.angularjs.org as a CDN. Consider changing this label to something like "our release repository" or just "code.angularjs.org".

jelbourn · 2022-03-10T00:03:27Z

@Splaktar I've changed the top banner message to be inside the same container as the version picker to avoid the overlapping and updated the various top styles to adjust, seems okay now on various viewport sizes. I also made the container opaque because I wouldn't ignore the transparency 😑

I've also changed that "CDN" text to "Release archive".

Splaktar · 2022-03-10T07:20:50Z

docs/config/templates/app/indexPage.template.html

+              <a href="https://goo.gle/angularjs-end-of-life">
+                read the end of life announcement
+              </a>.<br>


Suggested change

<a href="https://goo.gle/angularjs-end-of-life">

read the end of life announcement

</a>.<br>

<a href="https://goo.gle/angularjs-end-of-life">read the end of life announcement</a>.<br>

This fixes the space before the period:

After:

Splaktar · 2022-03-10T07:22:16Z

docs/config/templates/app/indexPage.template.html

+              <a href="https://goo.gle/angularjs-end-of-life">
+                read the end of life announcement
+              </a>.<br>
+              Visit <a href="https://angular.io">https://angular.io</a> for the actively supported


Suggested change

Visit <a href="https://angular.io">https://angular.io</a> for the actively supported

Visit <a href="https://angular.io">angular.io</a> for the actively supported

The https:// may be unnecessary in the banner, where space is somewhat limited.

Removed https:// from the link label 👍

mgechev

With the proposed changes by other reviewers, LGTM!

* Docs homepage * Docs banner * Security and support pages * GitHub README * CHANGELOG

* Docs homepage * Docs banner * Security and support pages * GitHub README * CHANGELOG (cherry picked from commit 757d56e)

jelbourn requested review from mgechev and gkalpak January 31, 2022 22:10

Splaktar reviewed Feb 1, 2022

View reviewed changes

gkalpak approved these changes Feb 2, 2022

View reviewed changes

aaronfrost reviewed Feb 3, 2022

View reviewed changes

aaronfrost reviewed Feb 7, 2022

View reviewed changes

jelbourn force-pushed the closing-time branch from 259927f to 4ddc91e Compare February 9, 2022 23:27

Splaktar approved these changes Feb 10, 2022

View reviewed changes

aaronfrost approved these changes Feb 10, 2022

View reviewed changes

This was referenced Mar 3, 2022

docs(eol): updates for End-of-Life angular/material#12152

Merged

docs(eol): update docs website for End-of-Life angular/material#12153

Merged

jelbourn force-pushed the closing-time branch from 4ddc91e to 98e6251 Compare March 10, 2022 00:00

jelbourn mentioned this pull request Mar 10, 2022

docs: update readme with end-of-life message angular/bower-angular#49

Merged

Splaktar reviewed Mar 10, 2022

View reviewed changes

mgechev approved these changes Mar 15, 2022

View reviewed changes

docs(*): update end-of-life messages

b733298

* Docs homepage * Docs banner * Security and support pages * GitHub README * CHANGELOG

jelbourn force-pushed the closing-time branch from 98e6251 to b733298 Compare March 18, 2022 16:29

jelbourn merged commit 757d56e into angular:master Mar 18, 2022

jelbourn added a commit that referenced this pull request Mar 18, 2022

docs(*): update end-of-life messages (#17177)

05c65be

* Docs homepage * Docs banner * Security and support pages * GitHub README * CHANGELOG (cherry picked from commit 757d56e)

docs: update end-of-life messages #17177

docs: update end-of-life messages #17177

jelbourn commented Jan 31, 2022

Splaktar left a comment

Splaktar Feb 1, 2022

gkalpak Feb 2, 2022

mgechev Feb 3, 2022

jelbourn Feb 9, 2022

gkalpak left a comment

gkalpak Feb 2, 2022

aaronfrost Feb 3, 2022

jelbourn Feb 9, 2022

aaronfrost Feb 3, 2022

jelbourn Feb 9, 2022

aaronfrost Feb 3, 2022

jelbourn Feb 9, 2022

aaronfrost Feb 3, 2022

jelbourn Feb 9, 2022

aaronfrost Feb 3, 2022

jelbourn Feb 9, 2022

aaronfrost Feb 3, 2022

jelbourn Feb 9, 2022

Splaktar commented Feb 10, 2022 •

edited

Splaktar left a comment

Splaktar Feb 10, 2022

jelbourn commented Mar 10, 2022

Splaktar Mar 10, 2022

Splaktar Mar 10, 2022

jelbourn Mar 18, 2022

mgechev left a comment

		[Support for legacy AngularJS has fully ended.](https://goo.gle/angularjs-end-of-life)
		Visit https://github.com/angular/angular for the actively supported Angular framework.


		You can read more about these plans in our [blog post announcement](https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c).

		### Extended Long Term Support

	Visit <a href="https://angular.io">https://angular.io</a> for the actively supported
	Visit <a href="https://angular.io">angular.io</a> for the actively supported

docs: update end-of-life messages #17177

docs: update end-of-life messages #17177

Conversation

jelbourn commented Jan 31, 2022

Splaktar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gkalpak left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Splaktar commented Feb 10, 2022 • edited

Desktop

Pixel 5

Splaktar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jelbourn commented Mar 10, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mgechev left a comment

Choose a reason for hiding this comment

Splaktar commented Feb 10, 2022 •

edited